Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve license check for Apache #867

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Improve license check for Apache #867

merged 1 commit into from
Feb 4, 2025

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 30, 2025

License:

License "Apache 2.0" is allowed as it is GPL compatible. This PR improves the license check and accepts few variations of the license text which as found in the directory.

Eg:

  • Apache License, Version 2.0
  • Apache License 2.0
  • Apache 2.0
  • Apache-2.0
  • Apache 2
  • Apache License 2

When normalizing, 2 is also kept as if somehow we encounter Apache 1.0, it should be blocked. So, I have kept normalized license like "Apache2".

@davidperezgar
Copy link
Member

Be aware that you have it in Draft.

@ernilambar ernilambar marked this pull request as ready for review January 31, 2025 23:29
Copy link

github-actions bot commented Jan 31, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Feb 4, 2025
@ernilambar ernilambar added this to the 1.5.0 milestone Feb 4, 2025
@ernilambar ernilambar merged commit c334a5f into trunk Feb 4, 2025
29 checks passed
@ernilambar ernilambar deleted the add/apache-license branch February 4, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants