Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try variable fonts as a means to reduce package size #603

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 21, 2024

Description

Partial for #401.
By replacing the separate font files with a single variable font, the package size can be decreased somewhat, and the size of theme.json is decreased as well.

Testing Instructions

Test the typography preset that uses the updated font families:
Manrope
Fira code
Platypi
Vollkorn
Ysabeau Office

Check that any visual changes are acceptable, since there may be some minor differences in the two formats.
Conform that the correct font style settings are available in the Typography panel > Appearance

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Carolina, from what I tested it looks good.

@beafialho
Copy link
Contributor

Thank you for making this change! If my testing is showing accurately, these are looking similar to the previous ones to me. Just to confirm, do they look like the screenshots below to you as well? If so, this is ok to merge.

Captura de ecrã 2024-10-23, às 09 29 44
Captura de ecrã 2024-10-23, às 09 32 15
Captura de ecrã 2024-10-23, às 09 31 10

@juanfra
Copy link
Member

juanfra commented Oct 24, 2024

Yes, it is looking like the screenshots to me. I'm merging this one then.

@juanfra juanfra merged commit 582e1d2 into trunk Oct 24, 2024
5 checks passed
@juanfra juanfra deleted the try/variable-fonts branch October 24, 2024 14:00
@juanfra
Copy link
Member

juanfra commented Oct 24, 2024

Thank you all!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants