Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Style Variation: Ice #433

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Style Variation: Ice #433

merged 4 commits into from
Sep 22, 2023

Conversation

MaggieCabrera
Copy link
Collaborator

@MaggieCabrera MaggieCabrera commented Sep 20, 2023

Description

This adds the Sans serif variation following the discussion from #367 (comment)

I wasn't sure about the font weights to use (also google fonts doesn't provide any italics for Inter). If this is good we can do the same for the dark sans serif one, which probably will need a name too.

Seems like the patterns are working as intended:

Screenshot 2023-09-20 at 11 18 25

@beafialho
Copy link

Thanks @MaggieCabrera, I reviewed it and in the sans-serif variation, the headings have slightly smaller sizes. I set them in Global Styles and also set them to use Bold. Here's the variation file:

ice_1.json.zip

In Google Fonts, Inter doesn't provide italics, but it does here, maybe we can use them?

@MaggieCabrera
Copy link
Collaborator Author

Looks like I misundertood and Rich meant to use Inter on the body font, I will be updating with that change and adding the italics

@luminuu luminuu changed the title Ice variation Style Variation: Ice Sep 20, 2023
@MaggieCabrera
Copy link
Collaborator Author

@beafialho I'm sorry for the confusion but I misunderstood which font was going to change to Inter. Rich made the change to change the body font in the theme to Inter, so this variation the only change that is making is change the heading font to use System font. Does that sound ok to you? do you think it needs any other tweaks?

@beafialho
Copy link

Rich made the change to change the body font in the theme to Inter, so this variation the only change that is making is change the heading font to use System font. Does that sound ok to you? do you think it needs any other tweaks?

That sounds ok, it's looking good 👍🏼 In the file below are some tweaks: I made the headings Bold, and customised the quote and pullquotes.

ice-2.json.zip

@MaggieCabrera
Copy link
Collaborator Author

there is another version designed on figma that is exactly like this one but with the colors of onyx, we still haven't build that. What should we name it?

@luminuu luminuu merged commit dae5e87 into trunk Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants