Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

add margin auto #478

Merged
merged 1 commit into from
Oct 14, 2020
Merged

add margin auto #478

merged 1 commit into from
Oct 14, 2020

Conversation

GuidoOffermans
Copy link
Collaborator

Fixes #468

Summary

Added margin auto to center the block.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  1. Create a new post.
  2. add a block-quote.
  3. Check if the alignment is correct in the editor.

Screenshots

If this is a visual change please include screenshots of the change at various screen sizes.

Desktop (Extra Large)
Desktop (Large)
Tablet (Medium)
Mobile (Small)

Quality assurance

  • I have thought about any security implications this code might add.
  • I have checked that this code doesn't impact performance (greatly).
  • I have tested this code to the best of my abilities
  • I have checked that this code does not affect the accessibility negatively

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Confirmed fix after running npm run build

@kjellr kjellr merged commit 3bc7f9e into trunk Oct 14, 2020
@kjellr kjellr deleted the block-quote-alignment-fix branch October 14, 2020 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The alignment of the block quote isn't inside the content width in the editor
3 participants