This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Reorder property and fix validation error in json files #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to the global style JSON files:
Move
$schema
andversion
to topRelated to #54, I think these two properties should be defined first.
Remove
title
propertyCurrently, the title property is not allowed in the schema, nor is it used in the site editor.
As Gutenberg issue, it has been suggested that the title be displayed in the preview, but I think that the incorrect property should be removed at this time.
Unified indentation
In the Marigold theme, tab indentation and space indentation were mixed, so they were unified into tab indentation.
Remove Incorrect style property
In the Marigold theme, the following incorrect border styles were defined:
This property was removed because it doesn't accept a boolean value and doesn't appear to be applied to the style.
Remaining problems
The code editor doesn't allow the
filter
property, but this is a problem on the JSON schema side and I would like to submit a separate PR to Gutenberg.If you have any questions about this PR, I would be happy to answer them.