-
Notifications
You must be signed in to change notification settings - Fork 92
Add the bird image to the homepage header #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, love that we can remove repetitive code. Assuming the Gutenberg PR lands, this LGTM.
To get the dark header, I selected the header template part and used replace. |
Also, the preview is not working for the dark header. which needs to be an upstream issue, if one hasn't already been opened |
Who has time to wait a full minute? :) (waiting doesn't help for this preview...) |
The problem with the |
I'm already seeing errors with this preview in
I moved the theme into a subfolder and things continued to work as expected. Even so, I tried out an alternate approach that uses a pattern just for the text + bird image, but it requires more code and also showed preview errors. So I'm not totally sure it's worth it. Would someone mind testing this out in a subfolder to see if it works or not? If it's still a bug, I can push that alternate approach for now. |
Thanks for testing. I wonder why it worked for me. 🤔 Anyway, I pushed that second, more elaborate method. Would you mind giving that a try next? |
This worked for me with the theme in a subfolder, no template part not found error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small typo fixes and this LGTM.
Co-authored-by: Jeff Ong <[email protected]>
Co-authored-by: Jeff Ong <[email protected]>
Fixes #92.
This PR uses the new pattern block to place the
header-large-dark
pattern in the homepage's header. Like #182, this PR relies on WordPress/gutenberg#36090 to get it to appear correctly.