Update Pattern edit_item string to Edit Block Pattern #4826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58716
Update the Pattern post type's
edit_item
label to beEdit Block Pattern
instead ofEdit Pattern
to resolve an edge case in Google Chrome whereEdit Pattern
causes the browser to think that the page is in German, and therefore displays the translation popup.After some digging, I couldn't work out why exactly Google Chrome thinks that the page is in German based on the string
Edit Pattern
, but my suspicion is that the server-rendered view of the block editor doesn't involve very many words, which could potentially contribute to it not recognising the language correctly (it appears to ignore thelang
attribute set on the page). Updating toEdit Block Pattern
appears to resolve the issue.Testing instructions
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.