Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.4 Backport: Add new wp patterns package #5235

Conversation

glendaviesnz
Copy link

@glendaviesnz glendaviesnz commented Sep 18, 2023

Description

Adds the newly created @wordpress/patterns package. Currently there is duplicated code for adding patterns in post editor (imported from reusable-blocks) and site editor (local modal component), which means any changes need to be applied in two places, so the patterns package was added in order to allow sharing of this code, and also as a means to start slowly deprecating the @wordpress/reusable-blocks package

Trac ticket: https://core.trac.wordpress.org/ticket/59380

Testing Instructions

This can't be properly tested until the latest GB packages are backported.

  • In the post editor add a block and use the Create pattern block menu to create both a synced and an unsynced pattern and make sure both options work as expected
  • In the post editor make sure the Detach pattern and Manage patterns options on the block overflow menu work correctly
  • In the site editor pattern section use the + at the top of the left navigation to create both a synced and unsynced pattern and make sure both are created as expected
  • In the site editor block editor use the Create pattern block menu to create both a synced and an unsynced pattern and make sure both options work as expected and also make sure the Detach pattern and Manage patterns options on the block overflow menu work correctly

Screenshots or screencast

patterns-share.mp4

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! These PHP files are auto-generated during the build process after package updates so they should be committed together with the main package update PR, which will be done sometime later this week. If there are no manual changes to PHP files, there's no need for a separate PR!

mikachan added a commit to mikachan/wordpress-develop that referenced this pull request Sep 20, 2023
@tellthemachines
Copy link
Contributor

Closing in favour of #5262

mikachan added a commit to mikachan/wordpress-develop that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants