HTML API: Handle area, br, embed, keygen, wbr #5895

sirreal · 2024-01-18T13:36:46Z

Add "area", "br", "embed", "img", "keygen", "wbr" tag handling

A start tag whose tag name is one of: "area", "br", "embed", "img", "keygen", "wbr"
Reconstruct the active formatting elements, if any.
Insert an HTML element for the token. Immediately pop the current node off the stack of open elements.
Acknowledge the token's self-closing flag, if it is set.
Set the frameset-ok flag to "not ok".

This exception is currently unsupported, <br> is handled, but the special exception for </br> is not:

An end tag whose tag name is "br"
Parse error. Drop the attributes from the token, and act as described in the next entry; i.e. act as if this was a "br" start tag token with no attributes, rather than the end tag token that it actually is.

Trac ticket: https://core.trac.wordpress.org/ticket/60283

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2024-01-18T14:12:42Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

sirreal · 2024-01-18T15:37:58Z

src/wp-includes/html-api/class-wp-html-processor.php

+			// Obsolete
+			//
+			// This does not appear in https://html.spec.whatwg.org/#void-elements
+			// but it was a void tag and browsers treat it as such.
+			'KEYGEN' === $tag_name


sirreal · 2024-01-18T15:40:26Z

src/wp-includes/html-api/class-wp-html-processor.php

+			case '-BR':
+				$this->last_error = self::ERROR_UNSUPPORTED;
+				throw new WP_HTML_Unsupported_Exception( 'Closing BR tags require unimplemented special handling.' );


We can deal with this later, it's tricky 🙂

sirreal · 2024-01-18T15:43:20Z

@dmsnell Will you review please?

sirreal · 2024-01-18T16:31:42Z

I compared this with the html5lib-tests branch (#5794) and this includes 4 additional tests, no failures.

sirreal · 2024-01-19T13:35:59Z

KEYGEN has special handling in "in select" mode:

https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inselect

sirreal

Thanks for the fixes @dmsnell! Apart from one comment they look good.

sirreal · 2024-01-19T20:28:01Z

tests/phpunit/tests/html-api/wpHtmlProcessorSemanticRules.php

+	 * When this handling is implemented, this test should be removed and `test_br_end_tag_special_behavior`
+	 * should not be marked incomplete. It's not incorporated into the existing unsupported tag behavior test
+	 * because the opening tag is supported; only the closing tag isn't.


This mentions an incomplete test (by name test_br_end_tag_special_behavior) that we've removed. Let's remove the specific reference to that test.

thanks! good spotting. I've removed it.

dmsnell · 2024-01-19T21:42:26Z

Merged in https://core.trac.wordpress.org/changeset/57316
91e51f9

Updates from WordPress/wordpress-develop at f4dda54df785d0a6957dedda3648f7fab58b829f - Coding style changes. - WordPress/wordpress-develop#5762 Adds support for the "any other tag" sections in the HTML Processor. - WordPress/wordpress-develop#5539 Adds support for list elements in the HTML Processor. - WordPress/wordpress-develop#5897 Adds support for HR elements in the HTML Processor. - WordPress/wordpress-develop#5895 Adds support for the AREA, BR, EMBED, KEYGEN, and WBR elements in the HTML Processor. - WordPress/wordpress-develop#5903 Adds support for the PRE and LISTING elements in the HTML Processor. - WordPress/wordpress-develop#5913 Updates "all other tags" support in HTML Processor and updates list of void elements. - WordPress/wordpress-develop#5906 Adds support for the PARAM, SOURCE, and TRACK elements in the HTML Processor. - WordPress/wordpress-develop#5683 Provides mechanism to scan all tokens in an HTML document in the Tag Processor. The PHP files in the compatability layer are merged and maintained in the Core repo and all changes or updates need to happen first in Core and then be brought over to Gutenberg as built files. Co-authored-by: Sergey Biryukov <[email protected]> Co-authored-by: Jon Surrell <[email protected]>

Updates from WordPress/wordpress-develop at f4dda54df785d0a6957dedda3648f7fab58b829f - Coding style changes. - WordPress/wordpress-develop#5762 Adds support for the "any other tag" sections in the HTML Processor. - WordPress/wordpress-develop#5539 Adds support for list elements in the HTML Processor. - WordPress/wordpress-develop#5897 Adds support for HR elements in the HTML Processor. - WordPress/wordpress-develop#5895 Adds support for the AREA, BR, EMBED, KEYGEN, and WBR elements in the HTML Processor. - WordPress/wordpress-develop#5903 Adds support for the PRE and LISTING elements in the HTML Processor. - WordPress/wordpress-develop#5913 Updates "all other tags" support in HTML Processor and updates list of void elements. - WordPress/wordpress-develop#5906 Adds support for the PARAM, SOURCE, and TRACK elements in the HTML Processor. - WordPress/wordpress-develop#5683 Provides mechanism to scan all tokens in an HTML document in the Tag Processor. - WordPress/wordpress-develop#5907 Adds support for the INPUT element in the HTML Processor The PHP files in the compatability layer are merged and maintained in the Core repo and all changes or updates need to happen first in Core and then be brought over to Gutenberg as built files. Co-authored-by: Sergey Biryukov <[email protected]> Co-authored-by: Jon Surrell <[email protected]>

Updates from WordPress/wordpress-develop: - From: WordPress/wordpress-develop@54a09a7 - To: WordPress/wordpress-develop@7a71339 - Coding style changes. - WordPress/wordpress-develop#5762 Adds support for the "any other tag" sections in the HTML Processor. - WordPress/wordpress-develop#5539 Adds support for list elements in the HTML Processor. - WordPress/wordpress-develop#5897 Adds support for HR elements in the HTML Processor. - WordPress/wordpress-develop#5895 Adds support for the AREA, BR, EMBED, KEYGEN, and WBR elements in the HTML Processor. - WordPress/wordpress-develop#5903 Adds support for the PRE and LISTING elements in the HTML Processor. - WordPress/wordpress-develop#5913 Updates "all other tags" support in HTML Processor and updates list of void elements. - WordPress/wordpress-develop#5906 Adds support for the PARAM, SOURCE, and TRACK elements in the HTML Processor. - WordPress/wordpress-develop#5907 Adds support for the INPUT element in the HTML Processor - WordPress/wordpress-develop#5683 Provides mechanism to scan all tokens in an HTML document in the Tag Processor. - WordPress/wordpress-develop#5976 Avoids splitting text nodes on "<" character. - WordPress/wordpress-develop#5992 Only recognize true CDATA-lookalike nodes. - WordPress/wordpress-develop#5975 Prevent void tag nesting when calling `next_token()` - WordPress/wordpress-develop#6021 Reset parser state after seeking. - https://core.trac.wordpress.org/changeset/57528 Fix typo in setting token flag. - WordPress/wordpress-develop#6041 Ensure consecutive text is all joined into one text node. The PHP files in the compatability layer are merged and maintained in the Core repo and all changes or updates need to happen first in Core and then be brought over to Gutenberg as built files. Co-authored-by: sergeybiryukov <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: dmsnell <[email protected]>

sirreal added 2 commits January 18, 2024 14:37

Add "area", "br", "embed", "img", "keygen", "wbr" tag rules

c28ea1d

Test tweaks

2a80cd2

sirreal force-pushed the html-api/handle-tags-area_br_embed_keygen_wbr branch from fd04650 to 2a80cd2 Compare January 18, 2024 13:37

Mention ticket, add unsupported test

41f9527

sirreal added 2 commits January 18, 2024 16:10

Add unnestable test

839a715

Fix void nesting tests

4a50cc1

sirreal commented Jan 18, 2024

View reviewed changes

sirreal added 2 commits January 18, 2024 16:38

Fix lints

fd26b12

Fix lints

94e0ff8

sirreal commented Jan 18, 2024

View reviewed changes

sirreal marked this pull request as ready for review January 18, 2024 15:44

Remove implemented tags from unsupported list

8e3b3f2

dmsnell added 2 commits January 19, 2024 12:38

Merge branch 'trunk' into html-api/handle-tags-area_br_embed_keygen_wbr

02ffaae

Update tests, code styling, comments.

6f6e09b

sirreal commented Jan 19, 2024

View reviewed changes

Remove superfluous mention of being "incomplete" in test comment.

15658e2

dmsnell closed this Jan 19, 2024

dmsnell deleted the html-api/handle-tags-area_br_embed_keygen_wbr branch January 19, 2024 21:42

dmsnell mentioned this pull request Jan 23, 2024

HTML API: Backport updates from Core WordPress/gutenberg#58107

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTML API: Handle area, br, embed, keygen, wbr #5895

HTML API: Handle area, br, embed, keygen, wbr #5895

sirreal commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024

sirreal Jan 18, 2024

sirreal Jan 18, 2024

sirreal commented Jan 18, 2024

sirreal commented Jan 18, 2024

sirreal commented Jan 19, 2024

sirreal left a comment

sirreal Jan 19, 2024

dmsnell Jan 19, 2024

dmsnell commented Jan 19, 2024

HTML API: Handle area, br, embed, keygen, wbr #5895

HTML API: Handle area, br, embed, keygen, wbr #5895

Conversation

sirreal commented Jan 18, 2024 • edited Loading

github-actions bot commented Jan 18, 2024

Test using WordPress Playground

Some things to be aware of

sirreal Jan 18, 2024

Choose a reason for hiding this comment

sirreal Jan 18, 2024

Choose a reason for hiding this comment

sirreal commented Jan 18, 2024

sirreal commented Jan 18, 2024

sirreal commented Jan 19, 2024

sirreal left a comment

Choose a reason for hiding this comment

sirreal Jan 19, 2024

Choose a reason for hiding this comment

dmsnell Jan 19, 2024

Choose a reason for hiding this comment

dmsnell commented Jan 19, 2024

sirreal commented Jan 18, 2024 •

edited

Loading