Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: Fix invalid css for nested fullwidth layouts with zero padding applied #7036

Conversation

andrewserong
Copy link
Contributor

@andrewserong andrewserong commented Jul 16, 2024

Backport WordPress/gutenberg#63436 to core.

In the Layout block support, handle 0 values for padding as 0px in calc() rules. This resolves a bug for nested fullwidth layouts when zero padding is applied. Due to how calc() works, without supplying the unit, the rule will not work, resulting in a horizontal scrollbar. For more information see the original issue in the Gutenberg repo, or the fix.

Testing instructions

  1. Open a post or page.
  2. Open the code editor within the top editor options panel.
  3. Copy and paste this gist, which configures the conditions properly (nested align full blocks, with padding zeroed out on the parent).
  4. See no horizontal scroll in the site front end.

Note: the issue will still be present in the post editor until the JS packages that include the JS changes from WordPress/gutenberg#63436 are included in core.

Trac ticket: https://core.trac.wordpress.org/ticket/61656

Props: @richtabor for the fix.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@andrewserong andrewserong self-assigned this Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props andrewserong, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27
Copy link
Member

Thanks @andrewserong, The changes look good to me.

Copy link

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @andrewserong 👍

✅ PHP changes match WordPress/gutenberg#63436
✅ No horizontal scrollbar on the frontend

LGTM!

Screenshot 2024-07-18 at 4 37 53 PM

@noisysocks
Copy link
Member

Committed in r58750 and re-opened https://core.trac.wordpress.org/ticket/61656 to request backport to the 6.6 branch.

@noisysocks noisysocks closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants