-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Expose post_types
field to Templates REST API
#7530
base: trunk
Are you sure you want to change the base?
Feature: Expose post_types
field to Templates REST API
#7530
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Changes look good. @Debarghya-Banerjee Would you be able to extend the existing unit tests? |
Hi @martinkrcho , I have fixed the failing test cases. Can you please check it. Thanks. |
@martinkrcho, @Debarghya-Banerjee, Thanks for working on this! 👍 I would love to see this merged. Is there anything I could do to help you with the PR? |
We want to use post_type for filtering email templates. There is a PR that adds this property WordPress/wordpress-develop#7530 but it is not merged. This commit added the property and also future compatibility check so that we don't attempt to add it after the PR is merged. [MAILPOET-6356]
We want to use post_type for filtering email templates. There is a PR that adds this property WordPress/wordpress-develop#7530 but it is not merged. This commit added the property and also future compatibility check so that we don't attempt to add it after the PR is merged. [MAILPOET-6356]
We want to use post_type for filtering email templates. There is a PR that adds this property WordPress/wordpress-develop#7530 but it is not merged. This commit added the property and also future compatibility check so that we don't attempt to add it after the PR is merged. [MAILPOET-6356]
We want to use post_type for filtering email templates. There is a PR that adds this property WordPress/wordpress-develop#7530 but it is not merged. This commit added the property and also future compatibility check so that we don't attempt to add it after the PR is merged. [MAILPOET-6356]
We want to use post_type for filtering email templates. There is a PR that adds this property WordPress/wordpress-develop#7530 but it is not merged. This commit added the property and also future compatibility check so that we don't attempt to add it after the PR is merged. [MAILPOET-6356]
Updated tests look good to me. @Debarghya-Banerjee can you merge latest trunk and re-run tests? I would approve this if the tests run OK. |
Sure @martinkrcho will do that. |
Trac Ticket: Core-61308
Overview
This pull request adds a new
post_types
field to the existing WordPress REST API endpoint for templates (/wp/v2/templates
). This enhancement allows users to filter templates based on the post types they are intended for, thereby improving usability and functionality in the site editor templates screen.Changes Made
Modified
get_item_schema()
:Added a new property, post_types, to the JSON schema for templates.
The post_types field is defined as an array of strings, describing the associated post types for each template.
Updated
prepare_item_for_response()
:Implemented logic to fetch and include the post_types information in the API response.
Ensured that the post_types field is populated based on the associated post types stored in the template's metadata.
Benefits
Improved Filtering
: Users can now filter templates directly by their associated post types, making it easier to find relevant templates for specific content types.Enhanced API Usability
: By exposing the post_types field, we align the API capabilities with user expectations and common use cases.