Fatals in main web script result in a blank content area #1231
Labels
[Feature] PHP.wasm
[Package][@php-wasm] Logger
[Priority] Medium
[Type] Bug
An existing feature does not function as intended
[Type] UI / UX / User Experience
Comments
brandonpayton
added
[Type] Bug
adamziel
added a commit
that referenced
this issue
Apr 12, 2024
## What does this PR do? This PRrestores displaying the PHP output when a PHP error is encountered. It does that by attaching `response` to the error thrown by BasePHP and augmenting the Comlink transfer handler to pass that response between workers through postMessage. ## What problem does it solve? Prior to be0e783, script output was still shown for Fatal Errors. For example, when reproducing the memory-related errors under #1128, we used to see something like the following where page output was shown along with the Fatal Error that ended execution. But now that we are no longer returning a PHPResponse when there is a non-zero exit code, the content is not updated when running the same script. The error message is printed to the console, but the partial content is not visible to the user. Instead the previous content is left in place as if the script had not run at all. Closes #1231 ## Testing instructions Ensure the E2E tests pass
adamziel
added a commit
that referenced
this issue
Apr 12, 2024
## What does this PR do? This PR restores displaying the PHP output when a PHP error is encountered. It does that by attaching `response` to the error thrown by BasePHP and augmenting the Comlink transfer handler to pass that response between workers through postMessage. ## What problem does it solve? Prior to be0e783, script output was still shown for Fatal Errors. For example, when reproducing the memory-related errors under #1128, we used to see something like the following where page output was shown along with the Fatal Error that ended execution. But now that we are no longer returning a PHPResponse when there is a non-zero exit code, the content is not updated when running the same script. The error message is printed to the console, but the partial content is not visible to the user. Instead the previous content is left in place as if the script had not run at all. Closes #1231 ## Testing instructions Ensure the E2E tests pass
|
This is great. Thank you, @adamziel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prior to be0e783, script output was still shown for Fatal Errors. For example, when reproducing the memory-related errors under #1128, we used to see something like the following where page output was shown along with the Fatal Error that ended execution.
But now that we are no longer returning a PHPResponse when there is a non-zero exit code, the content is not updated when running the same script. The error message is printed to the console, but the partial content is not visible to the user. Instead the previous content is left in place as if the script had not run at all.
When running PHP normally, wouldn't the partial content be shown? It seems like Playground should show whatever output PHP would typically show.
Would it be possible for us to restore returning PHPResponse even when there is an error and use messaging or events to relay info for error logging?
cc @bgrgicak @adamziel
The text was updated successfully, but these errors were encountered: