-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Blueprint schema to remove alerts when using the shorthand
syntax
#1282
Comments
Hmm, the deprecation message reads: 'This experimental option will change without warning.\nUse steps instead." That's making it a bit clearer, that it's experimental and not obsolete. The JSON schema specs notice the deprecated property needs to be boolean. "The value of this keyword MUST be a boolean. When multiple occurrences of this keyword are applicable to a single sub-instance, applications SHOULD consider the instance location to be deprecated if any occurrence specifies a true value. If "deprecated" has a value of boolean true, it indicates that applications SHOULD refrain from usage of the declared property. It MAY mean the property is going to be removed in the future." |
@adamziel let me know if the implementation is cemented enough for the "deprecated" property to be removed, and I create a PR for it. |
Here's the original discussion (for reference/background):
|
The documentation is available: https://wordpress.github.io/wordpress-playground/blueprints-api/steps-shorthands |
Thank you @ironnysh. Wonderful. |
Fixes - #1282 ## Implementation details remove the deprecation lines from the schema
Fixes - #1282 ## Implementation details remove the deprecation lines from the schema
The siteOptions step and plugins aren't marked as deprecated anymore, so I'm going to close this issue. |
Now that Blueprint shorthand properties like `constants`, `siteOptions`, and `plugins` are here to stay and featured in the official docs, it's probably safe to remove the warnings from the schema (see these lines). Closes #1282
I think lack of deprecation info was just a documentation quirk, the |
When using VS Code to compose a Blueprint that contains the shorthand syntax of the
siteOptions
step andplugins
step, the editor alerts that these are deprecated:Now that shorthands are here to stay and featured in the official docs, it's probably safe to remove the warnings from the schema (see these lines).
BTW, the Builder doesn't identify the shorthand syntax as an error. Is it using another version of the schema for validation?
The text was updated successfully, but these errors were encountered: