GitHub Integration: Allow new themes/plugins to be exported in a PR

[mikachan]

Currently, when trying to create a PR for a theme that doesn't exist in the target GitHub repo, you see this error:

There was an unexpected error (Object does not exist), please try again.

It would be amazing if you could add new themes (and plugins) to a Playground instance in order to export them in a PR like above.

I originally thought this was related to #1296, but I think this is now more of an enhancement rather than a bug 😄

[mikachan]

Actually, I'm also seeing the same error when I try to create a PR for an existing theme (e.g. upsidedown):

I'm not sure if I'm doing something wrong, maybe the way I've formatted the repo URL or the path where the change should be committed?

[bgrgicak]

Duplicate of #1367

[mikachan]

Hi @bgrgicak 👋 I don't think this is a duplicate of #1367, this issue was about creating a new theme or plugin via the GitHub integration. I'm currently still seeing this error when I try to add a new theme:

[bgrgicak]

I don't think this is a duplicate of #1367, this issue was about creating a new theme or plugin via the GitHub integration. I'm currently still seeing this error when I try to add a new theme:

Sorry I assumed it was the same root cause so I closed it. It's open now.

[mikachan]

Sorry I assumed it was the same root cause so I closed it. It's open now.

No worries, thank you!

[bgrgicak]

@mikachan I tested this today and it seems to work for me. Could you please try it again and let me know if it works for you?

What I did:

• created a new empty repository
• opened Playground and connected to GitHub in the export modal
• filled in the export form and clicked export
• after the loader stopped I to the PR created message

Is this what you would like to do or did I miss something?

[mikachan]

Thanks for testing, @bgrgicak. I think your testing instructions are missing a step to create a new directory for a new theme or plugin within the Playground instance. These are the steps I'm following:

1. Open Playground and install the Create Block Theme plugin
2. Go to the Editor, click the spanner icon to open the Create Block Theme menu
3. Click "Create Blank Theme". This creates a new theme and therefore a new directory in the wp-content/themes directory.

4. Click "Export Pull Request to GitHub" from the Playground menu
5. Connect my GitHub account (I can't get past this step during my testing today in Chrome, Firefox or Safari)
6. On the next step, I'd usually say that I'd like to export a theme, type in the new theme directory name (in my case I'm using "test01"), and then set the a8c themes repo as the repo URL: https://github.com/Automattic/themes
7. This is when I see the "branch not found" error.

I hope this helps to test this!

[bgrgicak]

Thank you! I was able to recreate it, but when I click Create PR for a second time it works 😕

I will take another look at it to see why it fails sometimes.

[bgrgicak]

This is when I see the "branch not found" error.

The only way I was able to recreate this error is by creating a new repository and trying to export to it.
The reason for the error was that I didn't have permission to push to main.

Just to double check do you have permissions on that GitHub repository?
I have and it doesn't prevent me from creating PRs.

[mikachan]

Thanks for testing this, @bgrgicak. I can see your tests worked in the themes repo, however, I'm still seeing the same error (Branch not found).

Just to double check do you have permissions on that GitHub repository?

Yeah, I'm a maintainer on that repo 🙈 I've just tried on a personal repo and it works fine there, so it definitely seems related to the a8c themes repo.

@beafialho or @henriqueiamarino, could you please check if you're able to add new themes via Playground now?

[beafialho]

Thank you for your work on this!

I just tried to submit a new theme to the themes repo and I believe it worked, here's what I'm seeing:

The only comment I have is if I select the option "Create a new PR", which I did, the default description could be "The Shore: add theme" instead of "Update theme the-shore".

[bgrgicak]

I'm glad you got it working now! I will close this issue as it seems like there isn't anything for us to do.

The only comment I have is if I select the option "Create a new PR", which I did, the default description could be "The Shore: add theme" instead of "Update theme the-shore".

We can't do that today. We only have the folder name, to get the title we would need to parse it from the theme.
We would also need to detect if the theme exists to set add instead of update in the title.

I don't think that this is something we will have time to work on in the near future.