-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an error when activating a theme or plugin that doesn't exist #1391
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9f7c77d
Move log prepare to logger
bgrgicak 714adc7
Throw error when activating a theme that doesn't exist
bgrgicak 6913e34
GitHub export: Create new commits in your fork when writing to the up…
adamziel b5428a6
Fix theme path
bgrgicak da5a371
Catch wp_error when activating plugin
bgrgicak d5ba05d
Merge branch 'trunk' into fix/1347-check-if-exists-before-activating
bgrgicak 2d4371e
Update test blueprint
bgrgicak f7b59e2
Merge branch 'trunk' into fix/1347-check-if-exists-before-activating
bgrgicak 07720af
Check for null
bgrgicak d416e76
Merge branch 'trunk' into fix/1347-check-if-exists-before-activating
bgrgicak a81a539
Add success message
bgrgicak 68edf7f
Always try to activate by name if path didn't work
bgrgicak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,8 +63,18 @@ describe('Blueprints', () => { | |
it('enableMultisite step should re-activate the plugins', () => { | ||
const blueprint: Blueprint = { | ||
landingPage: '/wp-admin/plugins.php', | ||
plugins: ['hello-dolly'], | ||
steps: [{ step: 'enableMultisite' }], | ||
steps: [ | ||
{ step: 'login' }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This step started failing because it was missing the login step. |
||
{ | ||
step: 'installPlugin', | ||
pluginZipFile: { | ||
resource: 'wordpress.org/plugins', | ||
slug: 'hello-dolly', | ||
}, | ||
options: { activate: true }, | ||
}, | ||
{ step: 'enableMultisite' }, | ||
], | ||
}; | ||
cy.visit('/#' + JSON.stringify(blueprint)); | ||
cy.wordPressDocument() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to the PR. It removes tabs from log messages.