Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error when activating a theme or plugin that doesn't exist #1391

Merged
merged 12 commits into from
May 16, 2024
Merged

Throw an error when activating a theme or plugin that doesn't exist #1391

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9f7c77d
Move log prepare to logger
bgrgicak May 14, 2024
714adc7
Throw error when activating a theme that doesn't exist
bgrgicak May 14, 2024
6913e34
GitHub export: Create new commits in your fork when writing to the up…
adamziel May 14, 2024
b5428a6
Fix theme path
bgrgicak May 15, 2024
da5a371
Catch wp_error when activating plugin
bgrgicak May 15, 2024
d5ba05d
Merge branch 'trunk' into fix/1347-check-if-exists-before-activating
bgrgicak May 15, 2024
2d4371e
Update test blueprint
bgrgicak May 15, 2024
f7b59e2
Merge branch 'trunk' into fix/1347-check-if-exists-before-activating
bgrgicak May 15, 2024
07720af
Check for null
bgrgicak May 15, 2024
d416e76
Merge branch 'trunk' into fix/1347-check-if-exists-before-activating
bgrgicak May 16, 2024
a81a539
Add success message
bgrgicak May 16, 2024
68edf7f
Always try to activate by name if path didn't work
bgrgicak May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playground/blueprints/src/lib/steps/activate-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const activatePlugin: StepHandler<ActivatePluginStep> = async (
}
}

if ( is_wp_error( $response ) ) {
if ( is_wp_error( $response ) || is_null( $response ) ) {
bgrgicak marked this conversation as resolved.
Show resolved Hide resolved
throw new Exception( $response->get_error_message() );
}

Expand Down
Loading