-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: Add libjpeg and libwebp support #1393
Conversation
Thanks for working on this 🙏 . |
It works for PHP 7.4 – it needs rebuilding all the kitchen sink and node versions of PHP and double-checking the uploads. I might not be able to get this to completion this week – @sejas would you like to take over from here? |
I found some time to rebuild the wasm files, let's see if the tests pass and ship |
It doesn't seem like it worked for the older PHP versions, I think they need different compilation flags |
I couldn't get libwebp to work for PHP <= 7.3 – the compiler complained about libwebp not being compiled with |
Thanks again for working on this until completion. 🙌 |
Thank you for addressing! 🙏 This change should resolve the issue of WebP support in Studio by pointing to a new release of the Edit: php-wasm/node has been released with v0.7.20 https://www.npmjs.com/package/@php-wasm/node 👍 🙇 |
Adds libjpeg and libwebp support to kitchen-sink and node.js builds.
All PHP versions got libjpeg, but only PHP >= 7.4 got libwebp. Getting it to work on 7.0 – 7.3 will require additional explorations.
Related to #1381 and #1175.
Testing instructions