Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Puzzle app from the Playground website #1588

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

bgrgicak
Copy link
Collaborator

@bgrgicak bgrgicak commented Jul 9, 2024

Motivation for the change, related issues

The Puzzle app was used during WCEU 2024 to scan puzzle pieces.
Now after the event is over, we need to remove the app from Playground.WordPress.net.

If we want to bring it back for a future event, we can revert this PR.

Implementation details

The PR removes the redirect necessary for app routing to work and the build plugin which adds the Puzzle app to the Website build.

Testing Instructions (or ideally a Blueprint)

  • ensure all tests pass
  • npm run build:website && php -S localhost:9999 -t dist/packages/playground/wasm-wordpress-net
  • Open http://localhost:9999/puzzle/ and ensure you don't see the puzzle app

@bgrgicak bgrgicak requested a review from a team July 9, 2024 06:14
@bgrgicak bgrgicak self-assigned this Jul 9, 2024
@bgrgicak bgrgicak merged commit 19c7f97 into trunk Jul 9, 2024
5 checks passed
@bgrgicak bgrgicak deleted the remove/puzzle-app branch July 9, 2024 06:42
bgrgicak added a commit that referenced this pull request Jul 23, 2024
## Motivation for the change, related issues

We don't need the puzzle app anymore, so we can remove this package from
the Playground project.

If we ever want to use the app again we can revert this PR and
#1588. This should
add the app back to the Playground website.

## Implementation details

Removes all puzzle app code.

## Testing Instructions (or ideally a Blueprint)

- CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant