Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website UI: Explain the Logs modal #1666

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Aug 1, 2024

Motivation for the change, related issues

@juanmaguitar asked:

What's the purpose of the "View logs" option available in https://playground.wordpress.net/
The modal that appears when clicking that option doesn't seem to do nothing.

It's not the first time when this question comes up, so I added a placeholder text whenever there are no logs to display:

CleanShot 2024-08-01 at 16 03 56@2x

Testing Instructions (or ideally a Blueprint)

  1. Go to the logs modal after Playground is loaded
  2. Confirm the placeholder text shows up
  3. Trigger an error in devtools: setTimeout(() => {throw new Error('test');});
  4. Confirm the error showed up in the modal
  5. Search the modal with a query that doesn't match any log line
  6. Confirm you got a "No matching logs found." message

@adamziel adamziel self-assigned this Aug 2, 2024
@adamziel adamziel merged commit ddc3be8 into trunk Aug 2, 2024
5 checks passed
@adamziel adamziel deleted the error-logs-modal-explainer branch August 2, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant