@php-wasm/util: Publish TypeScript types #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1593 caused the `@php-wasm/util` package to be published without the `index.d.ts` type declarations file which causes the following TypeScript error: ``` Could not find a declaration file for module '@php-wasm/node'. ``` This PR adds the missing `dts()` plugin to vite.config.ts and enables publishing the declarations file. Before we can say #1662 is fixed, we'll need to merge this PR, release new packages, and confirm they import cleanly without any TypeScript errors. Ideally we'd have a smoke test for that right in the CI.
adamziel
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1593 caused the
@php-wasm/utilpackage to be published without theindex.d.tstype declarations file which causes the following TypeScript error:This PR adds the missing
dts()plugin to vite.config.ts and enables publishing the declarations file.I verified all the other packages (aside of
cli, which is fine) use thedts()plugin. However, before we can say #1662 is fixed, we'll need to merge this PR, release new packages, and confirm they import cleanly without any TypeScript errors.Ideally we'd have a smoke test for that right in the CI.