-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@php-wasm/universal : Add Phar support in php-wasm #1716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Looks great to me. I'll hold on with merging until next week to make sure someone's online to revert just in case.
@adamziel I'm currently trying to run the
with :
This stack trace looks somewhat familiar but is obviously hard to read. Do you have any insights or suggestions on how to make this more debuggable? |
@mho22 the Node.js build should give you the same error with all the c function names. I would so love to start shipping the JSPI build to the browser ms and server side environments that support it as it would solve all such errors in one swoop. |
@adamziel I made a mistake. I solved it and here is what returns With [#1093] implementation : And here is what returns This looks promising for the pull request I think. |
In my quest to correct the errors above I found out other elements to add into the
Should I update the current pull request ? |
Yes please, especially since we've had another |
@adamziel done 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although GitHub still shows merge conflicts
@adamziel My apologies. The conflicts have been resolved. But |
It seems like they passed after rebasing. Thank you @mho22! |
Based on issue #1241.
This is an initial pull request version. I may need further guidance to ensure it is ready for merging.