Use the correct imports in the generated .d.ts files #1742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using @wp-playground/client with TypeScript, the IDE doesn't seem
to be able to recognize types. This is because the published types
contain fragments such as:
Which are relative to the build directory on the building machine.
This PR sets the
pathsToAliases
option of thevite-dts-plugin
tofalse to retain the packages names in those declaration files.
Testing instruction
Run
npm run build
and grep thedist
directory for../../
. Thereshould be no matches:
Inspect a few files, such as
dist/packages/php-wasm/web/lib/get-php-loader-module.d.ts
, and confirm they import from the proper package names.Closes #1725
cc @brandonpayton