FS: Use the correct rm/rmdir method when moving files between mounts #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Not a directory or a symbolic link to a directory ``` It occured because we always attempted to remove the source file using `rmdir` instead of choosing either `rm` or `rmdir`. This PR introduces a proper check. ## Testing instructions Confirm the unit tests pass
adamziel
added
[Type] Bug
|
Test failures are unrelated, let's ship it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this problem occuring when moving files between mounts:
It occured because we always attempted to remove the source file using
rmdirinstead of choosing eitherrmorrmdir. This PR introduces a proper check.Once it's merged, let's tag a new
@wp-playground/clirelease.Testing instructions
Confirm the unit tests pass## Motivation for the change, related issues