Stop address bar from adding trailing slash to query params #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, adding query params to a dir URI in the address bar would lead to the address bar adding a trailing slash after the query params. Since the PHP request handler already redirects dir URIs to include a trailing slash, we can remove this code and stop the bug from happening.
brandonpayton
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Before this change, adding query params to a dir URI in the address bar would lead to the address bar adding a trailing slash after the query params.
For example, entering
/?query=paramwould become/?query=param/, which is undesired and incorrect.Thanks to @bgrgicak for pointing this out in #1789.
Implementation details
Since the PHP request handler already redirects dir URIs to include a trailing slash, we can remove this code and stop the bug from happening.
Testing Instructions (or ideally a Blueprint)
/?test=queryin the Playground web app address bar