Close Playground Manager by default #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users are accustomed to seeing WordPress fill most of the page when loading WordPress Playground, and after we launched the Playground Manager, we received feedback indicating it might be better to leave it closed by default.
brandonpayton
added
[Type] Bug
brandonpayton
changed the title
adamziel
approved these changes
Sep 30, 2024
adamziel
reviewed
Sep 30, 2024
| // Don't default to the site manager on mobile, as that would mean | ||
| // seeing something that's not Playground filling your entire screen – | ||
| // quite a confusing experience. | ||
| // NOTE: Please do not eliminate the cases in this siteManagerIsOpen expression, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Users are accustomed to seeing WordPress fill most of the page when loading WordPress Playground, and after we launched the Playground Manager, we received feedback indicating it might be better to leave it closed by default.
We are concerned that users won't be able to find the button to open the Playground Manager, but we can work to make that button clearer in a separate PR.
Closes #1815
Implementation details
We update the redux
siteManagerIsOpenstate default tofalsewhile preserving specific reasons it should be false, even if the overall default is changed back totrue.Testing Instructions (or ideally a Blueprint)
npm run dev, open Playground web app in a desktop browser, confirm that the Playground Manager UI is closed.