[Website] Use site slug as a stable scope #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
force-pushed
the
trunk
branch
2 times, most recently
from
4b541aa to
680cd19
Compare
## Change details With this PR, Playground sites will use a stable path such as `/scope:my-site-slug/` instead of a volatile, randomly generated one such as `/scope:0.489625368/`. ## Motivation WordPress stores URLs such as `<img src="">` and `<a href="">` in the post content in a raw form that includes the site path. However, Playground assigns each site a random one-time scope. This is a problem for persistent sites where you can upload an image today and have it referenced in a post as, say `<img src="/scope:98742/wp-uploads/img.jpg">` and still expect to have it working correctly tomorrow when the site URL changes to `/scope:1987578`. ## Testing instructions * Create a new site * Save it in the browser * Upload an image in a post * Save the post * Refresh the browser tab * Confirm that image still renders correctly * Do it again, but now upload that image before saving the site in the browser With the introduction of multiple persistent Playgrounds, the users will get to interact with the same site multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change details
With this PR, Playground sites will use a stable path such as
/scope:my-site-slug/instead of a volatile, randomly generated one such as/scope:0.489625368/.Motivation
WordPress stores URLs such as
<img src="">and<a href="">in the post content in a raw form that includes the site path. However, Playground assigns each site a random one-time scope. This is a problem for persistent sites where you can upload an image today and have it referenced in a post as, say<img src="/scope:98742/wp-uploads/img.jpg">and still expect to have it working correctly tomorrow when the site URL changes to/scope:1987578.Testing instructions
With the introduction of multiple persistent Playgrounds, the users will get to interact with the same site multiple times