[Remote] Remove the "light" PHP.wasm bundle and only ship the "kitchen-sink" build #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sink" one Maintaining the "light" PHP.wasm bundle is a burden (#1848), especially with the JSPI support on the horizon (#1339). Only 1.3% of Playgrounds are loaded with the `light` extension bundle (see #1848). Let's thus simplify the project maintenance and remove the "light" bundle. After this PR, every Playground will be loaded with the "kitchen-sink" extension bundle. This PR also drops the name "kitchen-sink". From now on, it's just "php", ## Testing instructions * Confirm Playground continues to work in the local dev env * Confirm the CI is green – it would perform a thorough test run of many user flows. Closes #1848
adamziel
added
[Type] Enhancement
|
We'll need to remove extensions-related E2E tests, but otherwise the code may be good to go. |
adamziel
changed the title
brandonpayton
approved these changes
Oct 8, 2024
| */ | ||
| phpExtensionBundles?: SupportedPHPExtensionBundle[]; | ||
| phpExtensionBundles?: any; |
There was a problem hiding this comment.
This looks fine, but it made me wonder:
Have we ever considered support for dynamically loading specific, optional PHP modules?
|
I'll go ahead and merge. With 1.3% usage, deploying a version without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining the "light" PHP.wasm bundle is a burden (#1848), especially with the JSPI support on the horizon (#1339). Only 1.3% of Playgrounds are loaded with the
lightextension bundle (see #1848).Let's thus simplify the project maintenance and remove the "light" bundle. After this PR, every Playground will be loaded with the "kitchen-sink" extension bundle. This PR also drops the name "kitchen-sink". From now on, it's just "php",
Developer notes
The web version of Playground at playground.wordpress.net no longer ships the
lightbuild of PHP.wasm. Instead, it only ships thekitchen-sinkbuild where popular PHP extensions are available (e.g. libxml, libopenssl). Note that thekitchen-sinkbuild was already used by 98.7% of Playgrounds and most users are not affected by this.This change will help Playground maintainers focus on a single version and enable solving a lot of PHP.wasm stability issues by migrating to JSPI.
The CLI version of Playground is unaffected by this change.
The following APIs are now deprecated. Playground will accept them without crashing, but they will no longer have any effect:
phpExtensionBundlesBlueprint settingphp-extension-bundleQuery API parameterFollow up work
Testing instructions
Closes #1848