Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote] Preserve PHP constants when saving a temporary site #1911

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

adamziel
Copy link
Collaborator

This PR ensures that Blueprint-defined constants, such as WP_DEBUG,
are preserved in OPFS when a temporary site is saved, and are defined
again on subsequent boot after a page reload

Testing plan

This PR ensures that Blueprint-defined constants, such as WP_DEBUG,
are preserved in OPFS when a temporary site is saved, and are defined
again on subsequent boot after a page reload

 ## Testing plan

* Go to http://localhost:5400/website-server/?login=yes
* Confirm you are logged in
* Save the site in OPFS
* Reload the browser tab
* Confirm you are still logged in
@adamziel adamziel added [Feature] OPFS [Type] Bug An existing feature does not function as intended [Package][@wp-playground] Website and removed [Feature] OPFS labels Oct 16, 2024
@adamziel adamziel merged commit 07fb8ba into trunk Oct 16, 2024
8 of 9 checks passed
@adamziel adamziel deleted the preserve-constants-in-stored-sites branch October 16, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] OPFS [Package][@wp-playground] Website [Type] Bug An existing feature does not function as intended
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant