Explicitly request no-cache to discourage WP Cloud from edge caching CORS proxy results #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added
[Type] Bug
brandonpayton
changed the title
brandonpayton
commented
Oct 23, 2024
| @@ -99,7 +99,7 @@ | |||
| curl_setopt($ch, CURLOPT_FOLLOWLOCATION, false); | |||
| $httpcode_sent = false; | |||
| curl_setopt($ch, CURLOPT_HEADERFUNCTION, function($curl, $header) use($targetUrl, &$httpcode_sent, $ch) { | |||
| if(!$httpcode_sent) { | |||
| if (!$httpcode_sent) { | |||
There was a problem hiding this comment.
Just adding a space for consistency.
| @@ -158,8 +159,11 @@ | |||
| http_response_code(502); | |||
| echo "Bad Gateway – curl_exec error: " . curl_error($ch); | |||
| } else { | |||
| $httpCode = curl_getinfo($ch, CURLINFO_HTTP_CODE); | |||
| @http_response_code($httpCode); | |||
| if (!$httpcode_sent) { | |||
There was a problem hiding this comment.
Since we may have already sent the HTTP response code and set $httpcode_sent, let's avoid setting the response code again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This PR attempts to disable WP Cloud edge caching of CORS proxy responses.
Closes #1920
Implementation details
This PR updates the CORS proxy to always include a
Cache-Control: no-cacheheader with normal proxy responses.Testing Instructions (or ideally a Blueprint)
cors-proxy-config.phpthat defines a truthyPLAYGROUND_CORS_PROXY_DISABLE_RATE_LIMITconstant. This disables rate-limiting checks which are irrelevant to this change.php -S localhost:7777Cache-Control: no-cacheheader