Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm install to demo instruction #20

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

eliot-akira
Copy link
Collaborator

@eliot-akira eliot-akira commented Sep 26, 2022

I noticed the README was missing a step, to install node modules before starting the dev script for the demo.

@@ -1,5 +1,5 @@
{
"name": "waasm-wordpress",
"name": "wasm-wordpress",
Copy link
Collaborator Author

@eliot-akira eliot-akira Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated to the main topic of the pull request, but I figured it's OK to include.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Copy link
Collaborator

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants