[PHP] Restore /internal files and Filesystem mounts after hotswapPhpRuntime is called #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-create the mounts destroyed during the hotSwapPHPRuntime call. Closes #1596 ## Context Without this PR, `hotSwapPHPRuntime()` does not: * Recreate the filesystem mounts * Restore the platform-level plugins stored in the /internal (e.g the SQLite integration plugin) Which results in WordPress losing access to local files and the database connectivity. This PR ensures the mounts are re-created and the platform-level plugins preserved. ## Testing instructions This PR comes with tests, so check the CI logs.
adamziel
added
[Type] Bug
adamziel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR,
hotSwapPHPRuntime()does not:Which results in WordPress losing access to local files and the database connectivity everytime the PHP runtime is rotated.
This PR ensures the mounts are re-created and the platform-level plugins preserved.
Closes #1596
Testing instructions
This PR comes with tests, so check the CI logs.