Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wp-now: rename downloadSqliteIntegrationPlugin function #249

Merged
merged 1 commit into from
May 4, 2023
Merged

wp-now: rename downloadSqliteIntegrationPlugin function #249

merged 1 commit into from
May 4, 2023

Conversation

sejas
Copy link
Collaborator

@sejas sejas commented May 4, 2023

Suggested here #188 (comment)

Proposed changes:

  • rename WPNow downloadSqlite to downloadSqliteIntegrationPlugin which is more explicit.

Testing instructions

  • Build packages nvm use && yarn install && yarn build
  • Delete the folder manually: ~/.wp-now/wordpress-versions
  • Run `nx preview wp-now start --path=/Users/path-to-your-theme-or-plugin"
  • Observe ~/.wp-now/wordpress-versions/latest exist and WordPress has started correctly.

@sejas sejas requested a review from adamziel May 4, 2023 16:38
@sejas sejas self-assigned this May 4, 2023
@sejas sejas mentioned this pull request May 4, 2023
Merged
adamziel
adamziel approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sejas !

@adamziel adamziel merged commit cda20fd into WordPress:trunk May 4, 2023
@sejas sejas deleted the update/rename-fn-download-sqlite-integration-plugin branch May 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamziel adamziel adamziel approved these changes

Assignees

@sejas sejas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sejas @adamziel