Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website query API: Continue plugin installs on error #605
Website query API: Continue plugin installs on error #605
Changes from 12 commits
797dce0
71f32d9
c6fbe1f
38791f2
71b2467
486a632
bc803cd
5fb2d41
1281355
4681f81
4722601
69eb4af
978a3fa
c8467b1
06d7f26
df14575
4243e59
b32c27b
c7b7920
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didResolve() === false
suggests the promise may still be pending. I wonder what would be a more descriptive name here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was tough to find a suitable naming for this
didResolve
function. I consulted MDN: Promise to see what the standard terminology is.In the end I settled on a verbose name
isSettledPromiseResolved
, to make it clear that it's checking an already settled promise for its resolved status.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the
onStepCompleted
handler throws an error, thestepPromise?.reject(error);
will run. It would be nice to just rethrow that error so the API consumer may notice and correct it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of rethrowing, the two lines
stepStatus?.resolve(result)
andonStepCompleted
have been moved below the try/catch clause. If the latter throws (by the user or an unexpected error), it bubbles up to the API consumer, the caller ofCompiledBlueprint.run()
.