Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Use inter font size properties for heading sizes. #37

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

ryelle
Copy link
Collaborator

@ryelle ryelle commented Dec 4, 2024

This updates the headings across the site to use the correct "Inter Heading" levels, and with the parent-theme change, also shrinks the headings on small screens. This also cleans up some redundant settings and classes, and fixes the font-weight on the "Alternative text" label.

Fixes #24, See WordPress/wporg-parent-2021#164

Screenshots

Before After
Screen Shot 2024-12-04 at 15 11 48 Screen Shot 2024-12-04 at 15 08 24
Screen Shot 2024-12-04 at 15 11 58 Screen Shot 2024-12-04 at 15 08 46
Screen Shot 2024-12-04 at 15 11 41 Screen Shot 2024-12-04 at 15 09 33
Screen Shot 2024-12-04 at 15 11 31 Screen Shot 2024-12-04 at 15 10 33

How to test the changes in this Pull Request:

  1. Set the parent theme to use Theme.json: Add custom properties for Inter Heading font sizes wporg-parent-2021#164
  2. Build the styles (in both repos)
  3. Ensure the font sizes match the design
  4. Shrink the browser to <600px, the heading sizes should drop down too.
  5. In addition to the screenshots above, the headings on pages like Guidelines & photo submission should also change

@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label Dec 4, 2024
@ryelle ryelle self-assigned this Dec 4, 2024
@ryelle ryelle merged commit 83d3dbd into trunk Dec 5, 2024
@ryelle ryelle deleted the try/inter-font-sizes branch December 5, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Style updates of headings
1 participant