Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-822 CLI improvements & cleanup. #13

Merged
merged 1 commit into from
Aug 13, 2015
Merged

CP-822 CLI improvements & cleanup. #13

merged 1 commit into from
Aug 13, 2015

Conversation

evanweible-wf
Copy link
Contributor

Issue

  • Initial implementation could use some minor cleanup and improvements to the CLI.

Changes

  • Consolidated utils, reporter, and TaskProcess class into single util.dart entry point
  • init task now includes a link to the dart_dev repo as a comment in the generated file
  • analyze and format tasks updated to include bin/ directory
  • CLI Improvements:
    • Catch the FormatException when an unsupported arg is used and display a helpful message along with the usage text instead of the stack trace
    • examples task now checks for the example/ directory and displays an error message if it doesn't exist
    • format task now verifies that dart_style is an immediate dependency and will display a helpful error message if that's not the case
    • test task now verifies that test is an immediate dependency and will display a helpful error message if that's not the case

Areas of Regression

  • n/a

Testing

  • ddev --unsupported should display an error message stating that the --unsupported option is not supported in addition to the standard usage text instead of displaying the FormatException stack trace
  • examples
    • warns if example/ directory doesn't exist
  • format
    • warns if dart_style isn't an immediate dependency (remove dart_style line from pubspec.yaml to test)
  • init
    • includes a link to dart_dev repo in generated tool/dev.dart file
  • test
    • warns if test isn't an immediate dependency (remove test line from pubspec.yaml to test)

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
fyi: @jayudey-wf

@trentgrover-wf
Copy link
Contributor

+1

1 similar comment
@maxwellpeterson-wf
Copy link
Member

+1

@maxwellpeterson-wf
Copy link
Member

@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title CLI improvements & cleanup. CP-822 CLI improvements & cleanup. Aug 13, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • all testing suggestions work as expected
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 13, 2015
CP-822 CLI improvements & cleanup.
@jayudey-wf jayudey-wf merged commit dc6b56f into master Aug 13, 2015
@trentgrover-wf trentgrover-wf deleted the improvements branch August 19, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants