Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-2858 Update gen-test-runner task based on feedback #184

Merged
merged 2 commits into from
Oct 26, 2016
Merged

CP-2858 Update gen-test-runner task based on feedback #184

merged 2 commits into from
Oct 26, 2016

Conversation

jayudey-wf
Copy link
Contributor

Issue

  • There was no way of knowing what command was used generated the 'generated file.'
  • When running the gen-test-runner task with the check flag the html was being overwritten

Changes

Source:

  • Added line to document the command used to generate the test runner
  • Don't create html file on check task

Tests:

  • modified current tests

Areas of Regression

  • failing tests

Testing

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@evanweible-wf
@dustinlessard-wf

FYI

@dustyholmes-wf
@spencerbradley-wf

@maxwellpeterson-wf
Copy link
Member

+1

2 similar comments
@evanweible-wf
Copy link
Contributor

+1

@trentgrover-wf
Copy link
Contributor

+1

@maxwellpeterson-wf
Copy link
Member

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit tests created/updated
  • All unit tests pass
    • manual CI

Merging into master.

@maxwellpeterson-wf maxwellpeterson-wf merged commit 867c62f into master Oct 26, 2016
@maxwellpeterson-wf maxwellpeterson-wf deleted the gen-test-runner-updates branch October 26, 2016 14:24
@rmconsole2-wf rmconsole2-wf mentioned this pull request Oct 26, 2016
Merged
@rmconsole2-wf rmconsole2-wf changed the title Update gen-test-runner task based on feedback CP-2858 Update gen-test-runner task based on feedback Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayudey-wf @maxwellpeterson-wf @evanweible-wf @trentgrover-wf