Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-2990 Fix README dependencies so that users can pull down the latest dart_dev #194

Merged

Conversation

regenvanwalbeek-wf
Copy link
Contributor

Issue

Following the existing dart_dev documentation, users will not be able to pull down the latest version of dart_dev

Changes

Tweak the dependencies in the documentation

Testing

Make a new project with a new pubspec.yaml. Add the listed dependencies and run pub get. Verify that dart_dev 1.5.2 is pulled down.

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@evanweible-wf
@dustinlessard-wf
@jayudey-wf

@evanweible-wf
Copy link
Contributor

+1, thanks for the contribution @regenvanwalbeek-wf!!

@maxwellpeterson-wf
Copy link
Member

+1

@rmconsole3-wf rmconsole3-wf changed the title Fix README dependencies so that users can pull down the latest dart_dev CP-2990 Fix README dependencies so that users can pull down the latest dart_dev Nov 18, 2016
@jayudey-wf
Copy link
Contributor

QA +1, doc change only

Merging into master

@jayudey-wf jayudey-wf merged commit 054085f into Workiva:master Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants