CP-839 New Task: Code Coverage #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanweible-wf
force-pushed
the
coverage
branch
3 times, most recently
from
4f06bcc to
11f62c0
Compare
| Directory report; | ||
| if (html) { | ||
| await coverage._generateReport(); | ||
| report = new Directory(_coverageDirectory); |
There was a problem hiding this comment.
should we go ahead and make coverage output directory configurable?
There was a problem hiding this comment.
yeah that's a good idea
|
+1 once merge conflicts are fixed |
evanweible-wf
force-pushed
the
coverage
branch
from
076a62c to
826c188
Compare
|
@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf rebased on latest master. |
|
+1 |
1 similar comment
|
+1 |
|
@jayudey-wf ready for merge |
|
QA Resource Approval: +10
Merging into master. |
jayudey-wf
added a commit
that referenced
this pull request
Aug 18, 2015
CP-839 New Task: Code Coverage
This was referenced Aug 18, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#9 New Task: Code Coverage
Also took care of #20 since it turned out to be necessary to get coverage working (coverage was running on hard coded port, and one of the tests runs coverage which would run on that same hard coded port).
Changes
Source:
config.coverageto dev.dart file generated byinittaskTests:
Areas of Regression
Testing
ddev test --integrationpassesCode Review
@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf