Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-3695: Quit test task early if dartium or content-shell on Dart 2 #285

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

corwinsheahan-wf
Copy link
Contributor

@corwinsheahan-wf corwinsheahan-wf commented Dec 28, 2018

Problem:

If the platform is specified as dartium or content-shell while running tests under Dart 2, we should fail early instead of doing a full build.

Solution:

Fail early if either platform is specified with an error message

Testing:

  • CI Passes
  • Switch to Dart 1, publink this branch into a Dart 1 project, and verify that the test task runs as expected.
  • switch to Dart 2, publink this branch into a dart 2 project, and verify that:
    • ddev test -p dartium and ddev test -p content-shell fail early (before attempting a build
    • ddev test -p chrome (or any other platform which is not dartium or content-shell runs normally.

@corwinsheahan-wf corwinsheahan-wf requested a review from a team as a code owner December 28, 2018 22:03
@corwinsheahan-wf corwinsheahan-wf changed the title AF-3565: Quit test task early if dartium or content-shell on Dart 2 AF-3695: Quit test task early if dartium or content-shell on Dart 2 Dec 28, 2018
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@georgelesica-wf
Copy link
Contributor

+1

@sebastianmalysa-wf
Copy link

QA +1

  • CI passes
  • dart 1 tasks run as expected
  • consumed this in w_module, switched to Dart 2
    - test did not run on dartium or content-shell and failed early with the following message: Test platforms that are incompatible with Dart 2 detected: {dartium} and Test platforms that are incompatible with Dart 2 detected: {content-shell}
    - tests ran as expected on chrome

@sebastianmalysa-wf
Copy link

@Workiva/release-management-pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants