CPLAT-4822: Fail test task if build_runner build
fails
#291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPLAT-4822
Problem
On Dart 2, the
test
task currently runs tests viabuild_runner test
, but unfortunately this command does not exit with a non-zero exit code if the build fails, which means that the dart_devtest
task can appear as though it passed when in fact no tests were even run.Solution
When necessary, run
build runner build
first and fail early if it exits with a non-zero exit code. If it succeeds, then we can proceed to run the tests viabuild_runner test
, knowing that they will actually run.Testing
Code Review
@maxwellpeterson-wf @smaifullerton-wk @seanburke-wf