Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-4822: Fail test task if build_runner build fails #291

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Mar 8, 2019

CPLAT-4822

Issue Status

Problem

On Dart 2, the test task currently runs tests via build_runner test, but unfortunately this command does not exit with a non-zero exit code if the build fails, which means that the dart_dev test task can appear as though it passed when in fact no tests were even run.

Solution

When necessary, run build runner build first and fail early if it exits with a non-zero exit code. If it succeeds, then we can proceed to run the tests via build_runner test, knowing that they will actually run.

Testing

  • CI passes
  • Verify this behavior against the latest react_tracing dart2 branch, which is where we discovered this issue

Code Review

@maxwellpeterson-wf @smaifullerton-wk @seanburke-wf

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole6-wk rmconsole6-wk changed the title Fail test task if build_runner build fails CPLAT-4822 Fail test task if build_runner build fails Mar 8, 2019
@charliekump-wf charliekump-wf changed the title CPLAT-4822 Fail test task if build_runner build fails CPLAT-4822: Fail test task if build_runner build fails Mar 8, 2019
@maxwellpeterson-wf
Copy link
Member

QA +1

  • CI passes
  • Verified in react_tracing that this branch properly fails early when running test task and the build fails
  • Verified in a project with a working build that it correctly runs tests after the build
  • Verified on Dart 1 that no build is run at all

@Workiva/release-management-pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants