-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-6557: Add release flag and config option to test task #308
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
@@ -57,6 +57,10 @@ class TestCli extends TaskCli { | |||
negatable: false) | |||
..addFlag('delete-conflicting-outputs', | |||
help: 'Deletes conflicting outputs during the build', negatable: false) | |||
..addFlag('release', | |||
abbr: 'r', | |||
negatable: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does negatable mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that you can also do --no-release
to turn the flag false
QA +1 Testing Performed:
|
@Workiva/release-management-pp |
Overview:
Sometimes, consumers want to run tests on dart2js compiled code in Dart 2. This technically can be done via an args separator, but this doesn't provide help info through the test task, and it also doesn't allow for a config option to be set.
This adds a top level flag to the test task, and a config option, for running tests in release mode.
Testing:
ddev test
runs normally on Dart 1 and Dart 2.ddev test -r
andddev test --release
run a build via dart2js in Dart 2, and has no effect on Dart 1.dev.dart
torelease = true
runs tests in release mode by default.