CPLAT-8079: Export FormatterInputs and support following links #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanweible-wf
changed the title
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
olesiathoms-wk
approved these changes
Nov 1, 2019
evanweible-wf
force-pushed
the
export_formatter_inputs
branch
from
b3b3076 to
33c56b7
Compare
rmconsole5-wk
changed the title
charliekump-wf
changed the title
evanweible-wf
commented
Nov 1, 2019
| @@ -37,6 +38,73 @@ void main() { | |||
|
|
|||
| expect(argParser.options['formatter-args'].type, OptionType.single); | |||
| }); | |||
|
|
|||
| group('getInputs', () { | |||
There was a problem hiding this comment.
It looks like these tests are all new, but I just moved it from below where it was named differently. The only new test is the followLinks one.
olesiathoms-wk
approved these changes
Nov 1, 2019
todbachman-wf
approved these changes
Nov 1, 2019
olesiathoms-wk
approved these changes
Nov 1, 2019
todbachman-wf
approved these changes
Nov 1, 2019
|
QA +1
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPLAT-8079
Consumers of
FormatTool.getInputs()may want to reference the return type of that method, so we should export that class.Also adds support to
FormatTool.getInputs()for following symlinks.