-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running dart_dev in mixed-version packages opted into null safety #373
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
LGTM - thanks for adding this @greglittlefield-wf! Would you mind adding a changelog entry for this? I think it makes sense as a patch, so the next version would be 3.8.4 |
@evanweible-wf Np, thanks for reviewing! Can do! |
QA +1
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
dart_dev currently fails to run in mixed-version packages that have opted into null safety but have some non-null-safe dependencies.
This is because, in those packages, the bootstrap script is run in sound null safety mode by default, which fails because dart_dev (and potentially other packages pulled in via the config) are not themselves null-safe.
This is what those errors look like:
When using a config.dart that's also opted out of null-safety via a language comment:
Solution
--no-sound-null-safety
flag, but this seemed more straightforward)config.dart
, copy that over to the run script. This will ensure that non-null-safe configs will continue to work even after dart_dev itself is migrated to null safety,Testing