Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs tests to use dart analyze #384

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

evanweible-wf
Copy link
Contributor

A newer version of the Dart SDK has removed dartanalyzer, so we need to update our docs tests to use dart analyze.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@autobot-wk
Copy link

Skynet test results failed initially for this build but were approved by evan.weible
https://wf-skynet-hrd.appspot.com/apps/test/smithy/3781042/1
Approval message: CI failures on beta/dev are known due to removal of dartanalyzer

@evanweible-wf
Copy link
Contributor Author

QA +1

  • This fixes the documentation tests. Remaining test failures are also due to removal of dartanalyzer, but are failing because the default behavior of ddev analyze is to use dartanalyzer and we can't easily change that without raising our minimum SDK, so we'll do that later.

@evanweible-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 2154eb7 into master Jul 26, 2022
@rmconsole6-wk rmconsole6-wk deleted the use_dart_analyze_in_docs_tests branch July 26, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants