-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-switch analyze and format commands when on certain Dart SDKs #398
Merged
rmconsole5-wk
merged 4 commits into
master
from
auto-switch-to-replacement-commands-for-analyze-and-format
Jan 31, 2023
Merged
Auto-switch analyze and format commands when on certain Dart SDKs #398
rmconsole5-wk
merged 4 commits into
master
from
auto-switch-to-replacement-commands-for-analyze-and-format
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanweible-wf
force-pushed
the
auto-switch-to-replacement-commands-for-analyze-and-format
branch
from
January 31, 2023 02:54
d3d7603
to
72740d2
Compare
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
QA+1 CI Passes and tested manually on binder_viewer which had failed trying to run dartanalyzer on dart 2.18. |
+1 |
dustinlessard-wf
approved these changes
Jan 31, 2023
@Workiva/release-management-p |
rmconsole-wf
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
rmconsole5-wk
deleted the
auto-switch-to-replacement-commands-for-analyze-and-format
branch
January 31, 2023 23:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart analyze
instead ofdartanalyzer
when on Dart SDK v2.18 or higher (dartanalyzer
was removed in this version).dart format
instead ofdartfmt
when on Dart SDK v2.15 or higher (dartfmt
was removed in this version).