Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-switch analyze and format commands when on certain Dart SDKs #398

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Jan 31, 2023

  • Automatically use dart analyze instead of dartanalyzer when on Dart SDK v2.18 or higher (dartanalyzer was removed in this version).
  • Automatically use dart format instead of dartfmt when on Dart SDK v2.15 or higher (dartfmt was removed in this version).

@evanweible-wf evanweible-wf force-pushed the auto-switch-to-replacement-commands-for-analyze-and-format branch from d3d7603 to 72740d2 Compare January 31, 2023 02:54
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf
Copy link
Member

QA+1 CI Passes and tested manually on binder_viewer which had failed trying to run dartanalyzer on dart 2.18.

@evanweible-wf
Copy link
Contributor Author

+1

@robbecker-wf
Copy link
Member

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 902dd07 into master Jan 31, 2023
@rmconsole5-wk rmconsole5-wk deleted the auto-switch-to-replacement-commands-for-analyze-and-format branch January 31, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants