Make run return nonnullable FutureOr<int> #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
robbecker-wf
commented
Jun 8, 2023
| @@ -44,7 +44,7 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - uses: dart-lang/setup-dart@v1 | |||
| with: | |||
| sdk: stable | |||
| sdk: 2.18.7 | |||
There was a problem hiding this comment.
since 3.0 got released to stable, it now doesn't work .. so avoiding that for now.
|
Closing in favor of a non-breaking change solution here #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating to null safety we missed making the run method return a non nullable FutureOr ... and that is causing weird casts and slight type mismatches in other tools. This fixes that since the exit code is either zero pass and non-zero for fail but should never be null.