CP-1070 Format: allow exclusions

[evanweible-wf]

Issue

• Addresses Format: Allow files/directories to be excluded #66

Changes

Source:

• Format config now has an exclude option that takes a list of string paths (directories, files, or both)
• If exclusions are specified, the list of files to format will be expanded manually (instead of letting dartfmt do it) and will skip any file that matches one of the given exclusion paths
• The CLI output will include a warning that lists all files that were excluded from being formatted

Tests:

• Integration test added to verify that an unclean file that is excluded does not get formatted

Areas of Regression

• Format task

Testing

• Integration tests pass
• Play around with different values in the exclude list and verify that the files you'd expect to be excluded are indeed skipped

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

fyi: @aaronlademann-wf @greglittlefield-wf @clairesarsam-wf

[codecov-io]

Current coverage is 48.05%

Merging #81 into master will not affect coverage as of 09b7bc4

Powered by Codecov. Updated on successful CI builds.

[maxwellpeterson-wf]

+1

[trentgrover-wf]

+1
@jayudey-wf ready for merge

[jayudey-wf]

can you update the readme with this change?

[evanweible-wf]

@jayudey-wf I purposely left it out of the readme because it goes against dartfmt's philosophy (see https://github.com/dart-lang/dart_style#why-cant-i-tell-the-formatter-to-ignore-a-region-of-code). There were requests for this functionality since some of our component code gets mangled, so I've included it, but I prefer that it remain a dark feature.

[jayudey-wf]

QA Resource Approval: +10

• Testing instruction
• Dev +1's
• Dev/QA +10 with detail of what was tested
  • integration test pass
  • verified that files intended to be excluded were indeed excluded and then reported on as well in the dart_dev task
• Unit test created/updated
• All unit tests pass

Merging into master.

[jayudey-wf]

@Rosie run_merge_script