Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit #2

Merged
merged 24 commits into from
Apr 10, 2024
Merged

initial commit #2

merged 24 commits into from
Apr 10, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Apr 5, 2024 •
edited
Loading

Initial commit for gha-dart-oss

Notably missing is the release process and unit tests

These will be created as a followup

@rmconsole-wf
Copy link

rmconsole-wf commented Apr 5, 2024 •
edited by rmconsole4-wk
Loading

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s): None found in title
Code Review(s): #2
Release Image Tags:

Reviewers: robbecker-wf, matthewnitschke-wk, todbachman-wf

Additional Information

	When this pull is merged I will add it to the following release:
	Version: gha-dart-oss 0.1.0
	Release Ticket(s): None

Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Wednesday, April 10 04:27 PM CST

@aviary3-wk
Copy link

aviary3-wk commented Apr 5, 2024 •
edited
Loading

Security Insights

The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(1) Security relevant changes were detected
  • Watched file aviary.yaml added

    • Action Items

    • Request infosec review via Slack: #support-infosec
    • Verify aviary.yaml coverage of security relevant code

    Questions or Comments? Reach out on Slack: #support-infosec.

    @matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review April 5, 2024 21:33
    @matthewnitschke-wk matthewnitschke-wk mentioned this pull request Apr 5, 2024
    Closed
    robbecker-wf
    robbecker-wf previously approved these changes Apr 5, 2024
    View reviewed changes
    Copy link
    Member

    @robbecker-wf robbecker-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is a very full featured start

    @robbecker-wf
    Copy link
    Member

    security +1 on initial aviary.yaml file

    todbachman-wf
    todbachman-wf reviewed Apr 5, 2024
    View reviewed changes
    .github/workflows/checks.yaml Outdated

    jobs:
    analyze:
    runs-on: ubunut-latest
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Should this and the others below be:

    Suggested change
    runs-on: ubunut-latest
    runs-on: ubuntu-latest

    todbachman-wf
    todbachman-wf reviewed Apr 5, 2024
    View reviewed changes
    .github/workflows/checks.yaml Outdated
    run: dart pub global run dependency_validator

    analyze-additional-checks:
    runs-on: [self-hosted, xs, al2023]
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Should this be running on ubuntu-latest like the rest?

    todbachman-wf
    todbachman-wf previously approved these changes Apr 8, 2024
    View reviewed changes
    .github/workflows/checks.yaml Outdated
    workflow_call:
    inputs:
    package-path:
    description: The path to the package to run analysis on
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    description: The path to the package to run analysis on
    description: The path to the package to run checks on

    @matthewnitschke-wk
    Copy link
    Contributor Author

    QA +1

    • CI does indeed pass, no consumers

    🚀 @Workiva/release-management-p 🚢

    @rmconsole-wf
    Copy link

    @matthewnitschke-wk I will not merge this because:

    • 'Dependency Scan Clean' is False
    • 'Build successful' is False
    • dependencies not scanned

    todbachman-wf
    todbachman-wf approved these changes Apr 10, 2024
    View reviewed changes
    .github/workflows/_gha_build.yaml

    jobs:
    build:
    runs-on: [self-hosted, xs, al2023]
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Is it ok these 2 jobs are running on self-hosted runners?

    rmconsole-wf
    rmconsole-wf approved these changes Apr 10, 2024
    View reviewed changes
    Copy link

    @rmconsole-wf rmconsole-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    +1 from RM

    @rmconsole4-wk rmconsole4-wk merged commit 27011cc into master Apr 10, 2024
    22 checks passed
    @todbachman-wf todbachman-wf deleted the initial_commit branch April 10, 2024 21:27
    @rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Aug 6, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @todbachman-wf todbachman-wf todbachman-wf approved these changes

    @rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

    @robbecker-wf robbecker-wf Awaiting requested review from robbecker-wf

    Assignees
    No one assigned
    Labels
    Merge Requirements Met RM Ready
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @matthewnitschke-wk @rmconsole-wf @aviary3-wk @robbecker-wf @todbachman-wf @rmconsole4-wk