af_new_drydock_image

[dustinlessard-wf]

Purpose

The following pull request has been created by App Frameworks to help move consumers to the latest Smithy image. This was done because of an issue with Dartium and Content-Shell that would fail your CIs. Please seethis Wiki Questionfor additional context.

Changes

The following changes have been made:

• All instances of the production Smithy image have been updated to drydock-prod.workiva.net/workiva/smithy-runner-generator:355624.

Questions

If you have any questions, please reach out to us in the Support:H5 / Dart Hipchat room

[aviary-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on HipChat: InfoSec Forum.

[semveraudit-wf]

Public API Changes

No changes to the public API found for commit d2c0aca

Showing results for d2c0aca

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by semver-audit-dart 1.4.0
Browse public API.

Last edited UTC Jun 25 at 15:50:11

[codecov-io]

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files           3        3           
  Lines         478      478           
=======================================
  Hits          416      416           
  Misses         62       62

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ac8f2...d2c0aca. Read the comment docs.

[michaelcarter-wf]

This repo builds on Travis, do we still need this @dustinlessard-wf?

[robbecker-wf]

@michaelcarter-wf Looking at the smithy.yaml and Dockerfile ... this repo does not run any tests with either content-shell or dartium. So, we could just close this PR or just merge it in. If someone in the future decides to run tests in Workiva build with the old image, they will get the expired Dartium problem and their tests will hang.

[robbecker-wf]

+1

[robbecker-wf]

+10 CI passes (moved to Workiva build)

[michaelcarter-wf]

+10 / +1