Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a Completer's type #22

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Conversation

devoncarew
Copy link

@devoncarew devoncarew commented Jun 29, 2018

Fix a strong mode at runtime issue, where a signature was declared to return a Future<Schema>, but at runtime we were returning a Future<dynamic>.

If this looks good, do you mind doing a package publish? This library is consumed by the Flutter command line tool, and a publish would help us make it strong mode clean. Thanks!

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files           3        3           
  Lines         478      478           
=======================================
  Hits          416      416           
  Misses         62       62
Impacted Files Coverage Δ
lib/src/json_schema/schema.dart 81.94% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d8875...e90d125. Read the comment docs.

@michaelcarter-wf michaelcarter-wf merged commit d18b4ba into Workiva:master Jul 2, 2018
rm-astro-wf pushed a commit that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants